Skip to content

REGR: Fixed hash_key=None for object values #30900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2020
Merged

REGR: Fixed hash_key=None for object values #30900

merged 3 commits into from
Jan 13, 2020

Conversation

TomAugspurger
Copy link
Contributor

Closes #30887

@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 10, 2020
@jbrockmendel
Copy link
Member

could use a GH reference in the test, otherwise LGTM

@WillAyd WillAyd added the Regression Functionality that used to work in a prior pandas version label Jan 10, 2020
WillAyd
WillAyd approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TomAugspurger TomAugspurger merged commit dd6e31a into pandas-dev:master Jan 13, 2020
@TomAugspurger TomAugspurger deleted the 30887-hash-object branch January 13, 2020 15:22
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 13, 2020
@TomAugspurger @meeseeksmachine
Backport PR pandas-dev#30900: REGR: Fixed hash_key=None for object va…
ce401f0 
…lues
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 13, 2020
Merged
simonjayhawkins pushed a commit that referenced this pull request Jan 13, 2020
@meeseeksmachine @TomAugspurger @simonjayhawkins
Backport PR #30900: REGR: Fixed hash_key=None for object values (#30968)
0931386 
Co-authored-by: Tom Augspurger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Regression Functionality that used to work in a prior pandas version

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

Regression in hash_pandas_object with hash_key=None and object dtype

3 participants

@TomAugspurger @jbrockmendel @WillAyd